Skip to content

Conversation

@xhluca
Copy link
Owner

@xhluca xhluca commented Apr 28, 2019

Reverts #1

Xing added 30 commits April 28, 2019 15:16
…tures + handle_unknown='ignore' case (scikit-learn#12923)"

This reverts commit 374f621.
Xing added 25 commits April 28, 2019 15:16
…number of classes in Linear Discriminant Analysis (scikit-learn#12391)"

This reverts commit 6cae448.
@xhluca xhluca merged commit cceb8f7 into master Apr 28, 2019
@xhluca xhluca deleted the revert-1-master branch April 28, 2019 19:16
@xhluca xhluca restored the revert-1-master branch April 28, 2019 19:17
xhluca pushed a commit that referenced this pull request Apr 28, 2019
…13243)

* Remove unused code

* Squash all the PR 9040 commits

initial PR commit

seq_dataset.pyx generated from template

seq_dataset.pyx generated from template #2

rename variables

fused types consistency test for seq_dataset

a

sklearn/utils/tests/test_seq_dataset.py

new if statement

add doc

sklearn/utils/seq_dataset.pyx.tp

minor changes

minor changes

typo fix

check numeric accuracy only up 5th decimal

Address oliver's request for changing test name

add test for make_dataset and rename a variable in test_seq_dataset

* FIX tests

* TST more numerically stable test_sgd.test_tol_parameter

* Added benchmarks to compare SAGA 32b and 64b

* Fixing gael's comments

* fix

* solve some issues

* PEP8

* Address lesteve comments

* fix merging

* avoid using assert_equal

* use all_close

* use explicit ArrayDataset64 and CSRDataset64

* fix: remove unused import

* Use parametrized to cover ArrayDaset-CSRDataset-32-64 matrix

* for consistency use 32 first then 64 + add 64 suffix to variables

* it would be cool if this worked !!!

* more verbose version

* revert SGD changes as much as possible.

* Add solvers back to bench_saga

* make 64 explicit in the naming

* remove checking native python type + add comparison between 32 64

* Add whatsnew with everyone with commits

* simplify a bit the testing

* simplify the parametrize

* update whatsnew

* fix pep8
xhluca pushed a commit that referenced this pull request Apr 28, 2019
* initial commit

* used random class

* fixed failing testcases, reverted __init__.py

* fixed failing testcases #2
- passed rng as parameter to ParameterSampler class
- changed seed from 0 to 42 (as original)

* fixed failing testcases #2
- passed rng as parameter to SparseRandomProjection class

* fixed failing testcases scikit-learn#4
- passed rng as parameter to GaussianRandomProjection class

* fixed failing test case because of flake 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants