try dask.array #71
try dask.array #71
Conversation
Co-authored-by: Ryan Abernathey <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=======================================
Coverage 97.18% 97.18%
=======================================
Files 2 2
Lines 249 249
Branches 71 71
=======================================
Hits 242 242
Misses 5 5
Partials 2 2 Continue to review full report at Codecov.
|
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @aaronspring! FWIW I'm not sure this will make an large impact on what dependencies are installed. Dask's required dependencies are listed here
which are always installed, regardless if one pip installs dask, dask[array], dask[array, dataframe], dask[complete], etc.
Adding the [array] extra to the dask install will cause numpy to also be installed
This is probably a good thing as it will require xhistogram to install a numpy version which is compatible with dask.array, but will, as of today, not result in a big difference since numpy is listed as a separate dependency already.
That's all to say that this change seems totally reasonable, but isn't the cause for libraries like bokeh being installed as referenced over in #70
|
thanks @jrbourbeau for the quick description ok. so there is no way around so this PR here would only ensure that a matching |
ci/environment-3.7.yml
Outdated
| - python=3.7 | ||
| - xarray | ||
| - dask | ||
| - dask[array] |
There was a problem hiding this comment.
Ah, I see what the issue might be now. dask[array] (and my comment here #71 (review)) is just a pip thing and isn't supported when installing dask with conda. conda install dask will pull in other packages like bokeh though. Specifically the packages listed here.
If you just want to conda install the minimum required dependencies for Dask (which would be equivalent to pip install dask), you'll want to install the dask-core package from conda-forge.
There was a problem hiding this comment.
using dask-core reduces Setup Conda Env from 5:37 https://github.com/xgcm/xhistogram/runs/4258344230?check_suite_focus=true to 2:47 https://github.com/xgcm/xhistogram/runs/4258767295?check_suite_focus=true
|
thanks for the explanation. the originating issue was xarray-contrib/xskillscore#359, then we discovered that also |
|
If we are happy about this I will merge. 👍 if you think we are done here. |
|
happy to merge and maybe we can ship the |
3 participants
dask.arraydependency notdaskto speedup pip install #70, not successful