Little bug in firmware selection#46
Merged
xfangfang merged 3 commits intoxfangfang:mainfrom May 24, 2024
deviato:main
Merged
Conversation
There's a little bug that prevents to run the program with fw parameter values other than "base" ones (702 for example). In line 159 you determine the "base" offset by calling ``auto offset = getFirmwareOffset(fw);`` but later, in line 176 you try to set firmware offset with: ``if (exploit->setFirmwareVersion((FirmwareVersion) fw)) return 1;`` But that function only accepts "base" firmware versions, so it should be ``if (exploit->setFirmwareVersion((FirmwareVersion) offset)) return 1;``
Owner
|
Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a little bug that prevents to run the program with fw parameter values other than "base" ones (702 for example).
In line 159 you determine the "base" offset by calling
auto offset = getFirmwareOffset(fw);but later, in line 176 you try to set firmware offset with:
if (exploit->setFirmwareVersion((FirmwareVersion) fw)) return 1;But that function only accepts "base" firmware versions, so it should be
if (exploit->setFirmwareVersion((FirmwareVersion) offset)) return 1;