Skip to content

Added support for legacy alter table flag#848

Merged
gotson merged 4 commits intoxerial:masterfrom
talha970:legacy_alter_table_flag
Mar 11, 2023
Merged

Added support for legacy alter table flag#848
gotson merged 4 commits intoxerial:masterfrom
talha970:legacy_alter_table_flag

Conversation

@talha970
Copy link
Copy Markdown
Contributor

@talha970 talha970 commented Mar 6, 2023

Added support for legacy alter table flag
More info here

@gotson
Copy link
Copy Markdown
Collaborator

gotson commented Mar 7, 2023

hi, thanks for the PR. Can you run mvn spotless:apply and commit the changes ?

@gotson gotson linked an issue Mar 7, 2023 that may be closed by this pull request
Comment on lines +868 to +870
public void setLegacyAlterTableFlag(boolean use) {
set(Pragma.LEGACY_ALTER_TABLE, use);
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public void setLegacyAlterTableFlag(boolean use) {
set(Pragma.LEGACY_ALTER_TABLE, use);
}
public void setLegacyAlterTable(boolean flag) {
set(Pragma.LEGACY_ALTER_TABLE, flag);
}

Comment on lines +295 to +297
public void setLegacyAlterTableFlag(boolean use) {
config.setLegacyAlterTableFlag(use);
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public void setLegacyAlterTableFlag(boolean use) {
config.setLegacyAlterTableFlag(use);
}
public void setLegacyAlterTable(boolean flag) {
config.setLegacyAlterTable(flag);
}

Comment thread src/main/java/org/sqlite/SQLiteConfig.java
@talha970 talha970 requested a review from gotson March 9, 2023 21:33
*/
public void setLegacyAlterTableFlag(boolean use) {
set(Pragma.LEGACY_ALTER_TABLE, use);
public void setLegacyAlterTableFlag(boolean flag) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also change the name from setLegacyAlterTableFlag to setLegacyAlterTable to be consistent with other methods?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad didn't spot the method rename

*/
public void setLegacyAlterTableFlag(boolean use) {
config.setLegacyAlterTableFlag(use);
public void setLegacyAlterTableFlag(boolean flag) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also change the name from setLegacyAlterTableFlag to setLegacyAlterTable to be consistent with other methods?

@talha970 talha970 requested a review from gotson March 10, 2023 01:47
@gotson gotson merged commit 26df15f into xerial:master Mar 11, 2023
@gotson
Copy link
Copy Markdown
Collaborator

gotson commented Mar 11, 2023

thanks for your contribution!

@talha970
Copy link
Copy Markdown
Contributor Author

thank you for reviewing! Can you tell me the expected date of release?

@gotson
Copy link
Copy Markdown
Collaborator

gotson commented Mar 12, 2023

thank you for reviewing! Can you tell me the expected date of release?

no idea, there's a few PRs in flight to review.

The snapshot is already available, you can try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for PRAGMA legacy_alter_table

3 participants