Skip to content

Bad use of OutOfMemoryError to validate buffer size #629

New issue
New issue
Closed
Closed
Bad use of OutOfMemoryError to validate buffer size#629
@duongkame

Description

@duongkame
duongkame
opened on Jan 8, 2025

In SnappyInputStream, OutOfMemoryError is used to validate the buffer size to allocated.

snappy-java/src/main/java/org/xerial/snappy/SnappyInputStream.java

Lines 451 to 456 in dfbf67a

try {
compressed = new byte[chunkSize];
}
catch (java.lang.OutOfMemoryError e) {
throw new SnappyError(SnappyErrorCode.INVALID_CHUNK_SIZE, e.getMessage());
}

This's a bad way to validate buffer size as explain here.
And another serious consequence, catching OutOfMemoryError in Java code requires the applications not to use JVM options like CrashOnOutOfMemoryError or ExitOnOutOfMemoryError to automatically restart the JVM when it runs out of memory.

I'm wondering if there is a specific reason why that could not be a simple conditional validation?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions