internal: let ByteBuffer read 4 bytes as int in single call (#594)

bokken · web-flow · commit da1af8b26001 · 2024-09-10T12:22:47.000-07:00
diff --git a/src/main/java/org/xerial/snappy/SnappyFramedInputStream.java b/src/main/java/org/xerial/snappy/SnappyFramedInputStream.java
@@ -16,6 +16,7 @@
 import java.io.InputStream;
 import java.io.OutputStream;
 import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
 import java.nio.channels.Channels;
 import java.nio.channels.ClosedChannelException;
 import java.nio.channels.ReadableByteChannel;
@@ -669,17 +670,9 @@ private FrameMetaData getFrameMetaData(ByteBuffer frameHeader)
     private FrameData getFrameData(ByteBuffer content)
             throws IOException
     {
-        return new FrameData(getCrc32c(content), 4);
-    }
-
-    private int getCrc32c(ByteBuffer content)
-    {
-
-        final int position = content.position();
-
-        return ((content.get(position + 3) & 0xFF) << 24)
-                | ((content.get(position + 2) & 0xFF) << 16)
-                | ((content.get(position + 1) & 0xFF) << 8)
-                | (content.get(position) & 0xFF);
+        // the first 4 bytes are the crc32c value in little endian order
+        content.order(ByteOrder.LITTLE_ENDIAN);
+        final int crc32c = content.getInt(content.position());
+        return new FrameData(crc32c, 4);
     }
 }
