Allow manual coin selection in make offer#761
Merged
Conversation
|
Thanks @dkackman — tested this with our market maker bot and can confirm coin_ids selection works as expected. We're passing specific coin IDs to make_offer and the wallet correctly locks those exact coins for the offer. The auto-fill behaviour when selected coins are less than the offered amount also works well. Great addition, this gives us much better control over coin management for automated trading. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #760
fix #119
RPC only: now an optional list of coin ids can be used whem making an offer. If the total amount of the selected coins is less than the offered amount the difference will be auto selected.