Theme schema#640
Merged
Merged
Conversation
- Add backdrop-filter CSS variables for cards, popovers, surfaces, inputs, and tables - Include WebKit-prefixed variants for cross-browser compatibility - Extend Theme interface to support backdrop-filter properties in all button variants - Add backdrop-filter processing logic to applyTheme function - Create utility CSS classes for backdrop-filter effects - Auto-apply backdrop-filters to existing UI components (.bg-card, .bg-popover, inputs) - Add backdrop-filter variables to cleanup array for proper theme switching - Support backdrop-filter in table headers and footers - Enable glass-dark theme's blur effects to work properly This allows themes like glass-dark to use advanced backdrop-filter properties for modern frosted glass UI effects while maintaining backward compatibility with existing themes.
- Increase blur intensity and saturation for better foggy glass effect - Change all text to pure white for maximum contrast and legibility - Add subtle blue neon edge glows to all borders and shadows - Enhance glass transparency layers for premium feel - Optimize colors for cyberpunk aesthetic with blue accent theme
Add Dracattus theme
Add Glass Light theme
Add background images for themes
Add backdrop filter support for themes
Add sidebar background support for themes
Add sidebar border support for themes
Add sidebar backdrop filter support for themes
Add sidebar backdrop filter webkit support for themes
…ete button form showing though
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive theme schema system and various theme-related improvements. The main purpose is to add validation, better type safety, caching optimizations, and enhanced theme functionality.
- Introduces theme schema validation with JSON Schema to ensure theme consistency
- Refactors theme loading with caching and improved type definitions
- Adds new theme features like backdrop filters, sidebar styling, and switch theming
Reviewed Changes
Copilot reviewed 24 out of 26 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/themes/schema.json | Defines comprehensive JSON schema for theme validation |
| src/lib/theme.type.ts | New TypeScript interface definitions for theme structure |
| src/lib/theme-schema-validation.ts | Theme validation utilities using AJV |
| src/lib/themes.ts | Adds theme caching and invalidation functionality |
| src/lib/theme.ts | Major refactor with improved theme application and isolation |
| src/lib/color-utils.ts | Adds makeColorOpaque function and improves cleanup |
| src/hooks/useOpaqueColor.ts | New hook for creating opaque color versions |
| src/index.css | Extensive CSS variable additions for new theme features |
| multiple theme files | Adds schemaVersion field to all theme configurations |
| UI components | Various accessibility and theme-related improvements |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
align schema to the new lib
Rigidity
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR begins the finalization of the theme implementation