Skip to content

Fix: pasting option id is confusing#638

Merged
Rigidity merged 12 commits into
xch-dev:mainfrom
dkackman:bug-636
Sep 21, 2025
Merged

Fix: pasting option id is confusing#638
Rigidity merged 12 commits into
xch-dev:mainfrom
dkackman:bug-636

Conversation

@dkackman

@dkackman dkackman commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator

Fix #636
Fix #670

From Discord:
Pasting the option ID into the asset field does not pull up the asset when making offers.
Image
https://discord.com/channels/1220144003874553986/1220151049483059330/1411036148511412397

  • Same issue was in the nft selector
  • This also adds searching options by option id, underlying asset id and strike asset id, which were missed in the first release.
  • Also Add to offer was missing from the option card
  • prevent taking offers with expired options
  • fix weird behavior after pasting option of nft id - memoize id and remove doubled up change event

@dkackman dkackman changed the title Fix pasting option id is confusing Fix for pasting option id is confusing Aug 30, 2025
@dkackman dkackman changed the title Fix for pasting option id is confusing Fix: pasting option id is confusing Sep 11, 2025
@Rigidity Rigidity merged commit 17b62bd into xch-dev:main Sep 21, 2025
6 of 8 checks passed
@dkackman dkackman deleted the bug-636 branch April 19, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add NFT to offer no longer works (it creates a blank NFT in the offer) Pasting option ids into the selector does not work

2 participants