Repository navigation
Support multiple grid mappings; Add new GridMapping dataclass - #586
Merged
Merged
Conversation
dcherian
force-pushed
the
complex-grid-mapping
branch
from
September 3, 2025 16:06
309e18d to
c5dfc7a
Compare
dcherian
force-pushed
the
complex-grid-mapping
branch
2 times, most recently
from
September 3, 2025 17:17
d27d633 to
abee56f
Compare
dcherian
force-pushed
the
complex-grid-mapping
branch
from
September 3, 2025 17:18
abee56f to
5410abf
Compare
dcherian
changed the title
dcherian
commented
Sep 3, 2025
| name: str | ||
| crs: Any # really pyproj.CRS | ||
| array: xr.DataArray | ||
| coordinates: tuple[str, ...] |
Contributor
Author
There was a problem hiding this comment.
@aulemahal the cartopy_crs property could be added here with any workarounds.
dcherian
commented
Sep 3, 2025
aulemahal
approved these changes
Sep 3, 2025
aulemahal
left a comment
aulemahal
left a comment
Contributor
There was a problem hiding this comment.
Thanks for that, looks good!
I think the "coordinate" fallback might be a bit too broad.
dcherian
force-pushed
the
complex-grid-mapping
branch
from
September 3, 2025 23:04
ecbe054 to
87ccd42
Compare
Co-authored-by: Claude <[email protected]>
Co-authored-by: Claude <[email protected]>
dcherian
enabled auto-merge (squash)
September 4, 2025 15:31
dcherian
disabled auto-merge
September 4, 2025 15:31
dcherian
force-pushed
the
complex-grid-mapping
branch
from
September 4, 2025 15:41
ca823e5 to
da3a557
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@larsbuntemeyer can you take a look please