fix: 'ip_restriction_ranges' is not a create group field

jeremad · jeremad · commit f285de48fa40 · 2024-11-15T10:05:33.000+01:00
diff --git a/groups.go b/groups.go
@@ -384,7 +384,6 @@ type CreateGroupOptions struct {
 	ParentID                        *int                                    `url:"parent_id,omitempty" json:"parent_id,omitempty"`
 	SharedRunnersMinutesLimit       *int                                    `url:"shared_runners_minutes_limit,omitempty" json:"shared_runners_minutes_limit,omitempty"`
 	ExtraSharedRunnersMinutesLimit  *int                                    `url:"extra_shared_runners_minutes_limit,omitempty" json:"extra_shared_runners_minutes_limit,omitempty"`
-	IPRestrictionRanges             *string                                 `url:"ip_restriction_ranges,omitempty" json:"ip_restriction_ranges,omitempty"`
 	WikiAccessLevel                 *AccessControlValue                     `url:"wiki_access_level,omitempty" json:"wiki_access_level,omitempty"`
 
 	// Deprecated: Use EmailsEnabled instead
diff --git a/groups_test.go b/groups_test.go
@@ -783,32 +783,6 @@ func TestUnshareGroupFromGroup(t *testing.T) {
 	}
 }
 
-func TestCreateGroupWithIPRestrictionRanges(t *testing.T) {
-	mux, client := setup(t)
-
-	mux.HandleFunc("/api/v4/groups",
-		func(w http.ResponseWriter, r *http.Request) {
-			testMethod(t, r, http.MethodPost)
-			fmt.Fprint(w, `{"id": 1, "name": "g", "path": "g", "ip_restriction_ranges" : "192.168.0.0/24"}`)
-		})
-
-	opt := &CreateGroupOptions{
-		Name:                Ptr("g"),
-		Path:                Ptr("g"),
-		IPRestrictionRanges: Ptr("192.168.0.0/24"),
-	}
-
-	group, _, err := client.Groups.CreateGroup(opt, nil)
-	if err != nil {
-		t.Errorf("Groups.CreateGroup returned error: %v", err)
-	}
-
-	want := &Group{ID: 1, Name: "g", Path: "g", IPRestrictionRanges: "192.168.0.0/24"}
-	if !reflect.DeepEqual(want, group) {
-		t.Errorf("Groups.CreateGroup returned %+v, want %+v", group, want)
-	}
-}
-
 func TestUpdateGroupWithIPRestrictionRanges(t *testing.T) {
 	mux, client := setup(t)
 
