chore: improve IPRestrictionRanges test

jeremad · jeremad · commit 4f7ea733c05d · 2024-11-15T10:51:41.000+01:00
diff --git a/groups_test.go b/groups_test.go
@@ -785,21 +785,38 @@ func TestUnshareGroupFromGroup(t *testing.T) {
 
 func TestUpdateGroupWithIPRestrictionRanges(t *testing.T) {
 	mux, client := setup(t)
+	const ipRange = "192.168.0.0/24"
 
 	mux.HandleFunc("/api/v4/groups/1",
 		func(w http.ResponseWriter, r *http.Request) {
 			testMethod(t, r, http.MethodPut)
-			fmt.Fprint(w, `{"id": 1, "ip_restriction_ranges" : "192.168.0.0/24"}`)
+
+			body, err := io.ReadAll(r.Body)
+			if err != nil {
+				t.Fatalf("Failed to read the request body. Error: %v", err)
+			}
+
+			var bodyJson map[string]interface{}
+			err = json.Unmarshal(body, &bodyJson)
+			if err != nil {
+				t.Fatalf("Failed to parse the request body into JSON. Error: %v", err)
+			}
+
+			if bodyJson["ip_restriction_ranges"] != ipRange {
+				t.Fatalf("Test failed. `ip_restriction_ranges` expected to be '%v', got %v", ipRange, bodyJson["ip_restriction_ranges"])
+			}
+
+			fmt.Fprintf(w, `{"id": 1, "ip_restriction_ranges" : "%v"}`, ipRange)
 		})
 
 	group, _, err := client.Groups.UpdateGroup(1, &UpdateGroupOptions{
-		IPRestrictionRanges: Ptr("192.168.0.0/24"),
+		IPRestrictionRanges: Ptr(ipRange),
 	})
 	if err != nil {
 		t.Errorf("Groups.UpdateGroup returned error: %v", err)
 	}
 
-	want := &Group{ID: 1, IPRestrictionRanges: "192.168.0.0/24"}
+	want := &Group{ID: 1, IPRestrictionRanges: ipRange}
 	if !reflect.DeepEqual(want, group) {
 		t.Errorf("Groups.UpdatedGroup returned %+v, want %+v", group, want)
 	}
