Repository navigation
DRAFT try key_metadata_with_length - #4
Merged
xanderbailey merged 1 commit intoSep 18, 2026
Merged
Conversation
xanderbailey
commented
Sep 16, 2026
Comment on lines
-50
to
+75
| writer_future: WriterFuture, | ||
| output: ManifestOutput, |
Owner
Author
There was a problem hiding this comment.
I think before this change it made perfect sense to represent the ManifestWriterBuilder as just having "something that can write" but now that's not enough, it needs to carry more information about what is being written so the enum is actually defensible now.
Owner
Author
There was a problem hiding this comment.
Note this isn't a pub api break also which is nice.
xanderbailey
commented
Sep 16, 2026
Comment on lines
-214
to
-215
| key_metadata: Option<StandardKeyMetadata>, | ||
|
|
Owner
Author
There was a problem hiding this comment.
This is nice to remove now since you don't have a full StandardKeyMetadata until you've actually written
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?