Skip to content
This repository was archived by the owner on Dec 14, 2024. It is now read-only.

Support proxy setting in config#60

Merged
xalanq merged 1 commit intoxalanq:masterfrom
Tribleave:master
Feb 27, 2020
Merged

Support proxy setting in config#60
xalanq merged 1 commit intoxalanq:masterfrom
Tribleave:master

Conversation

@Tribleave
Copy link
Copy Markdown
Contributor

@Tribleave Tribleave commented Feb 27, 2020

As mentioned in #55, proxy setting in config now supported. User can set http/https/socks5 proxy in an additional config selection. Due to safety concerns, proxy with username and password is not supported.
A minor version updating is also conducted because of the new feature.

@Tribleave Tribleave changed the title Support proxy setting in config. See #55 Support proxy setting in config Feb 27, 2020
@xalanq
Copy link
Copy Markdown
Owner

xalanq commented Feb 27, 2020

Maybe the proxy url could be stored in configuration file?

@Tribleave
Copy link
Copy Markdown
Contributor Author

Yep, current proxy url is stored in ~/.cfsession file.

@xalanq
Copy link
Copy Markdown
Owner

xalanq commented Feb 27, 2020

Yep, current proxy url is stored in ~/.cfsession file.

I knew. But I suggest you store it in ~/.cfconfig

@Tribleave
Copy link
Copy Markdown
Contributor Author

Oh, I see. Since the host setting is stored in ~/cfsession file, I decided to put proxy URL in it when implementing. However, the proxy setting is about network connection, and I think this way seems more natural and more convenient.

@xalanq xalanq merged commit e3546a6 into xalanq:master Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants