This repository was archived by the owner on Dec 14, 2024. It is now read-only.
login using email and case-insensitive username added#43
Closed
pratapaditya1997 wants to merge 1 commit intoxalanq:masterfrom
Closed
login using email and case-insensitive username added#43pratapaditya1997 wants to merge 1 commit intoxalanq:masterfrom
pratapaditya1997 wants to merge 1 commit intoxalanq:masterfrom
Conversation
Owner
|
I think it's too complicated. There is a simpler way to do that. match, err := regexp.Match(fmt.Sprintf(`handle = "%v"`, username), body)=> match, err := regexp.Match(fmt.Sprintf(`(?i)handle = "%v"`, username), body) |
Author
|
I don't think it will work while logging in with the user email which is also a requirement. |
Owner
|
Thanks for your work! I'll handler it on this weekend or next weekend. |
Owner
|
Fix it by match, err := regexp.Match(`handle = "[\s\S]+?"`, body) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#40
I made this flow on top of your existing CheckLogin flow so that it will never break your existing code. I have kept the code as generic as possible. I tested this on my local and it worked fine. Please check on your end too