Allow map_in_place to be called when the callee is already panicking.#300
Merged
xacrimon merged 1 commit intoJun 17, 2024
Merged
Allow map_in_place to be called when the callee is already panicking.#300xacrimon merged 1 commit into
xacrimon merged 1 commit into
Conversation
dtzxporter
commented
Apr 24, 2024
dtzxporter
commented
Contributor
- Forget the abort on panic once we know the closure did not panic.
- Forget the abort on panic once we know the closure did not panic. Update util.rs
dtzxporter
changed the title
Contributor
Author
|
CI issue is unrelated to PR |
Contributor
Author
|
@xacrimon Gentle bump on this, it's a pretty harmless change that makes the api usable in Drop(s) where the callee has panicked! |
Owner
|
@dtzxporter Apologies for the delay. Thanks for this! Will put out a new version this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.