Skip to content

Conversation

@xabbuh
Copy link
Owner

@xabbuh xabbuh commented Sep 3, 2024

No description provided.

@xabbuh xabbuh changed the base branch from 7.2 to phpunit11-iniset September 3, 2024 13:24
@xabbuh xabbuh force-pushed the phpunit11 branch 2 times, most recently from 489f41b to 93c6ee1 Compare September 3, 2024 15:21
@xabbuh xabbuh changed the base branch from phpunit11-iniset to phpunit11-preparation September 4, 2024 07:26
@xabbuh xabbuh force-pushed the phpunit11 branch 2 times, most recently from ddca744 to 6fa6989 Compare September 5, 2024 17:23
@xabbuh xabbuh force-pushed the phpunit11 branch 2 times, most recently from 8e411a5 to 8670997 Compare September 23, 2024 08:54
@xabbuh xabbuh force-pushed the phpunit11-preparation branch from 7a4af4e to 5d02fa1 Compare September 23, 2024 10:57
@xabbuh xabbuh force-pushed the phpunit11-preparation branch from 5d02fa1 to 9467400 Compare September 23, 2024 12:52
@xabbuh xabbuh closed this Sep 23, 2024
@xabbuh xabbuh deleted the phpunit11 branch September 23, 2024 12:54
xabbuh pushed a commit that referenced this pull request Nov 13, 2025
…eout must be positive` (Jeroeny)

This PR was merged into the 6.4 branch.

Discussion
----------

[HttpClient] Fix `Warning: curl_multi_select(): timeout must be positive`

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

Full error text: `ErrorException: Warning: curl_multi_select(): timeout must be between 0 and 2147484`

Somehow this timeout is a negative float in some cases. I haven't been able to reproduce it manually. Here's an example:

<img width="979" height="920" alt="image" src="https://github.com/user-attachments/assets/57e44026-cb1a-412c-acb2-b94ec13de48e" />

```
ErrorException: Warning: curl_multi_select(): timeout must be between 0 and 2147484
#0 /vendor/symfony/http-client/Response/CurlResponse.php(342): Symfony\Component\HttpClient\Response\CurlResponse::select
#1 /vendor/symfony/http-client/Response/TransportResponseTrait.php(298): Symfony\Component\HttpClient\Response\CurlResponse::stream
#2 /vendor/symfony/http-client/Response/CommonResponseTrait.php(148): Symfony\Component\HttpClient\Response\CurlResponse::initialize
#3 /vendor/symfony/http-client/Response/TransportResponseTrait.php(130): Symfony\Component\HttpClient\Response\CurlResponse::doDestruct
#4 /vendor/symfony/http-client/Response/CurlResponse.php(242): Symfony\Component\HttpClient\Response\CurlResponse::__destruct
#5 /vendor/sentry/sentry/src/Client.php(177): Sentry\Client::captureEvent
#6 /vendor/sentry/sentry/src/State/Hub.php(155): Sentry\State\Hub::captureEvent
#7 /vendor/sentry/sentry/src/Tracing/Transaction.php(188): Sentry\Tracing\Transaction::finish
#8 /vendor/..redacted(): ...::shutdownHandler
#9 [internal](0)
```

Not sure if this is the place to enforce the `>=0` float or in https://github.com/symfony/symfony/blob/7.4/src/Symfony/Component/HttpClient/Response/CurlResponse.php#L363

Commits
-------

17eec0c Fix Warning: curl_multi_select(): timeout must be positive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants