Repository navigation
Commit d155a33
authored
[material_ui] Fix MenuAnchor non-Unicode shortcut labels on JS web (flutter#13370)
Delegate unlocalized trigger fallback in `_LocalizedShortcutLabeler.getShortcutLabel` directly to `trigger.keyLabel` instead of masking `keyId` with `LogicalKeyboardKey.planeMask` (`0x0ff00000000`), which truncates to `0` under 32-bit JS bitwise `&` and renders keys like `Tab` and `F1` as raw char codes (`\t`, `\u0801`).
Fixes flutter/flutter#195003
## Pre-Review Checklist
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.1 parent d2e97da commit d155a33
3 files changed
Lines changed: 49 additions & 10 deletions
File tree
- packages/material_ui
- lib/src
- pending_changelogs
- test
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2622 | 2622 | | |
2623 | 2623 | | |
2624 | 2624 | | |
2625 | | - | |
2626 | 2625 | | |
2627 | 2626 | | |
2628 | 2627 | | |
2629 | 2628 | | |
2630 | 2629 | | |
2631 | | - | |
2632 | | - | |
2633 | | - | |
2634 | | - | |
2635 | | - | |
2636 | | - | |
2637 | | - | |
2638 | | - | |
2639 | | - | |
| 2630 | + | |
2640 | 2631 | | |
2641 | 2632 | | |
2642 | 2633 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4461 | 4461 | | |
4462 | 4462 | | |
4463 | 4463 | | |
| 4464 | + | |
| 4465 | + | |
| 4466 | + | |
| 4467 | + | |
| 4468 | + | |
| 4469 | + | |
| 4470 | + | |
| 4471 | + | |
| 4472 | + | |
| 4473 | + | |
| 4474 | + | |
| 4475 | + | |
| 4476 | + | |
| 4477 | + | |
| 4478 | + | |
| 4479 | + | |
| 4480 | + | |
| 4481 | + | |
| 4482 | + | |
| 4483 | + | |
| 4484 | + | |
| 4485 | + | |
| 4486 | + | |
| 4487 | + | |
| 4488 | + | |
| 4489 | + | |
| 4490 | + | |
| 4491 | + | |
| 4492 | + | |
| 4493 | + | |
| 4494 | + | |
| 4495 | + | |
| 4496 | + | |
| 4497 | + | |
| 4498 | + | |
| 4499 | + | |
| 4500 | + | |
| 4501 | + | |
| 4502 | + | |
| 4503 | + | |
| 4504 | + | |
| 4505 | + | |
| 4506 | + | |
| 4507 | + | |
| 4508 | + | |
4464 | 4509 | | |
4465 | 4510 | | |
4466 | 4511 | | |
| |||
0 commit comments