Fix argument parsing for '--precluster-ani'#8
Merged
wwood merged 1 commit intowwood:masterfrom Sep 1, 2020
Merged
Conversation
Owner
|
Thanks. I thought I'd fixed this actually, but clearly hadn't. Pity clap cannot handle multiple .long arguments, now maintaining backwards compatibility is too painful. I will also add something to the release notes. Hope you like the new release more generally. |
Contributor
Author
|
Thanks! The new release seems great! Thanks for your hard work on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @wwood
I was testing the new release and I noticed that every time I used
--precluster-aniI got the following error:Using
prethreshold-aniinstead worked as expected.It seems clap only recognizes the last long name you define for the argument. Because
precluster-aniis how this argument is called in the manual, I removed the line that setsprethreshold-anias the long name.