airframe-jdbc: Refine JDBC connection pool#858
Merged
xerial merged 4 commits intowvlet:masterfrom Dec 17, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #858 +/- ##
==========================================
- Coverage 81.03% 80.98% -0.05%
==========================================
Files 228 229 +1
Lines 9004 9028 +24
Branches 651 646 -5
==========================================
+ Hits 7296 7311 +15
- Misses 1708 1717 +9
Continue to review full report at Codecov.
|
takezoe
approved these changes
Dec 17, 2019
Member
takezoe
left a comment
takezoe
left a comment
There was a problem hiding this comment.
Looks good. Making components independent from airframe-di as much as possible might be a good habit since we can use them without airframe or with other DI containers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #387