Skip to content

Upgrade Scala.js to 1.0.0-RC2#821

Merged
xerial merged 11 commits intowvlet:masterfrom
xerial:scalajs-rc1
Dec 13, 2019
Merged

Upgrade Scala.js to 1.0.0-RC2#821
xerial merged 11 commits intowvlet:masterfrom
xerial:scalajs-rc1

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Nov 22, 2019 •
edited
Loading

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 22, 2019 •
edited
Loading

Codecov Report

Merging #821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #821   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files         228      228           
  Lines        9004     9004           
  Branches      651      651           
=======================================
  Hits         7296     7296           
  Misses       1708     1708

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0a1f4...48a870e. Read the comment docs.

@xerial xerial mentioned this pull request Nov 22, 2019
Closed
@xerial xerial mentioned this pull request Dec 5, 2019
Closed
76 tasks
@xerial xerial changed the title Upgrade Scala.js to 1.0.0-RC1 Upgrade Scala.js to 1.0.0-RC2 Dec 11, 2019
@xerial xerial mentioned this pull request Dec 12, 2019
Closed
@xerial
Copy link
Copy Markdown
Member Author

xerial commented Dec 13, 2019 

[error] java.lang.NoClassDefFoundError: jdk/internal/reflect/MethodAccessorImpl
[error] 	at java.base/jdk.internal.misc.Unsafe.defineClass0(Native Method)
[error] 	at java.base/jdk.internal.misc.Unsafe.defineClass(Unsafe.java:1192)

This error happens at the first test attempt, but it cannot be reproduced in the second attempt.

@xerial
Copy link
Copy Markdown
Member Author

xerial commented Dec 13, 2019

By separating airspec / airframe builds the linker error was resolved

@xerial xerial merged commit 6b458dc into wvlet:master Dec 13, 2019
@xerial xerial deleted the scalajs-rc1 branch December 13, 2019 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xerial