airframe-codec: Support Base64 encoded binary#819
Merged
xerial merged 4 commits intowvlet:masterfrom Nov 22, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #819 +/- ##
==========================================
- Coverage 81.03% 80.95% -0.08%
==========================================
Files 224 224
Lines 8894 8904 +10
Branches 616 620 +4
==========================================
+ Hits 7207 7208 +1
- Misses 1687 1696 +9
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will close #634
Previously airframe-codec encodes binary values as UTF-8 strings, but it may have caused data loss. This PR will use Base64 for representing binary values when generating JSON data.
Similarly, when reading string values to Array[Byte], try decoding the strings as Base64 binaries. If it fails, it will fall back to using the raw string byte arrays of the string.
This encoding is also used in Open API https://swagger.io/docs/specification/data-models/data-types/#string
cc: @takezoe @shimamoto