airframe-di: Support in-class bind[X] for classes with DISupport trait#816
Merged
xerial merged 3 commits intowvlet:masterfrom Nov 21, 2019
Merged
airframe-di: Support in-class bind[X] for classes with DISupport trait#816xerial merged 3 commits intowvlet:masterfrom
xerial merged 3 commits intowvlet:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
==========================================
+ Coverage 81.03% 81.03% +<.01%
==========================================
Files 224 224
Lines 8893 8894 +1
Branches 616 616
==========================================
+ Hits 7206 7207 +1
Misses 1687 1687
Continue to review full report at Codecov.
|
shimamoto
approved these changes
Nov 21, 2019
Collaborator
shimamoto
left a comment
shimamoto
left a comment
There was a problem hiding this comment.
Left one minor comment, but basically it's good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.