Skip to content

airframe-http-finagle: Add Finagle.client builder#760

Merged
xerial merged 6 commits intowvlet:masterfrom
xerial:finagle-client-builder
Oct 4, 2019
Merged

airframe-http-finagle: Add Finagle.client builder#760
xerial merged 6 commits intowvlet:masterfrom
xerial:finagle-client-builder

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Oct 4, 2019

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 4, 2019

Codecov Report

Merging #760 into master will decrease coverage by <.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
- Coverage    83.3%   83.29%   -0.01%     
==========================================
  Files         217      219       +2     
  Lines        8624     8645      +21     
  Branches      602      604       +2     
==========================================
+ Hits         7184     7201      +17     
- Misses       1440     1444       +4
Impacted Files Coverage Δ
...airframe/examples/http/Http_02_ObjectMapping.scala 20% <ø> (ø) ⬆️
...rc/main/scala/wvlet/airframe/http/HttpClient.scala 100% <ø> (ø) ⬆️
...in/scala/wvlet/airframe/http/finagle/Finagle.scala 100% <100%> (ø)
.../wvlet/airframe/examples/http/Http_03_Client.scala 100% <100%> (ø)
...la/wvlet/airframe/http/finagle/FinagleClient.scala 89.24% <81.25%> (-2.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4251c84...e26631a. Read the comment docs.

@xerial xerial merged commit 48f44cb into wvlet:master Oct 4, 2019
@xerial xerial deleted the finagle-client-builder branch October 4, 2019 20:42
This was referenced Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant