Skip to content

airframe-config: Add @secret annotation#710

Merged
xerial merged 2 commits intowvlet:masterfrom
xerial:config-printer
Sep 12, 2019
Merged

airframe-config: Add @secret annotation#710
xerial merged 2 commits intowvlet:masterfrom
xerial:config-printer

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Sep 12, 2019

Resolves #137

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 12, 2019

Codecov Report

Merging #710 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   83.25%   83.28%   +0.02%     
==========================================
  Files         216      216              
  Lines        8503     8518      +15     
  Branches      607      603       -4     
==========================================
+ Hits         7079     7094      +15     
  Misses       1424     1424
Impacted Files Coverage Δ
...scala/wvlet/airframe/surface/reflect/package.scala 90.47% <ø> (ø) ⬆️
...irframe/src/main/scala/wvlet/airframe/Design.scala 92.95% <100%> (+0.1%) ⬆️
.../src/main/scala/wvlet/airframe/config/Config.scala 98.8% <100%> (+0.25%) ⬆️
...src/main/scala/wvlet/airframe/config/package.scala 88.46% <100%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d3cba...8071eed. Read the comment docs.

@xerial xerial merged commit c82008f into wvlet:master Sep 12, 2019
@xerial
Copy link
Copy Markdown
Member Author

xerial commented Sep 12, 2019

@takezoe @shimamoto @Lewuathe We can use this annotation for marking configuration parameters that should not be shown in logs

@xerial xerial deleted the config-printer branch September 12, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an annotation for hidden config paramters

1 participant