airframe-surface: Support inner classes#635
Merged
xerial merged 10 commits intowvlet:masterfrom Aug 24, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
==========================================
+ Coverage 81.53% 81.53% +<.01%
==========================================
Files 242 242
Lines 8783 8807 +24
Branches 672 675 +3
==========================================
+ Hits 7161 7181 +20
- Misses 1622 1626 +4
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will support creating Surface.of[X] for inner classes by providing the context class instance when creating a surface.
It would be possible to support Scala.js, but I didn't add this as we will not use this in Scala.js.
@takezoe, @smdmts