Skip to content

airframe-http-recorder: Add createRecorderProxy#557

Merged
xerial merged 3 commits intowvlet:masterfrom
xerial:recorder-book
Jul 29, 2019
Merged

airframe-http-recorder: Add createRecorderProxy#557
xerial merged 3 commits intowvlet:masterfrom
xerial:recorder-book

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Jul 28, 2019

Added a new filter for replaying for known requests or recording for unknown requests.

  • Changed record/replay Services as Finagle filters for composability
  • Moved dropSession flag to server factory methods
  • Renamed factory methods: createRecorderProxy, createRecordOnlyServer, createReplayOnlyServer.

@xerial xerial requested a review from takezoe July 28, 2019 19:29
@xerial xerial changed the title airframe-http-recorder: Add createRecorderProxyServer airframe-http-recorder: Add createRecorderProxy Jul 28, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 28, 2019

Codecov Report

Merging #557 into master will increase coverage by <.01%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   83.71%   83.71%   +<.01%     
==========================================
  Files         224      224              
  Lines        8208     8212       +4     
  Branches      616      609       -7     
==========================================
+ Hits         6871     6875       +4     
  Misses       1337     1337
Impacted Files Coverage Δ
...wvlet/airframe/http/recorder/HttpRecordStore.scala 97.56% <100%> (-0.06%) ⬇️
...et/airframe/http/recorder/HttpRecorderServer.scala 100% <100%> (ø) ⬆️
...la/wvlet/airframe/http/recorder/HttpRecorder.scala 96.42% <92.85%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308e22a...80b7e74. Read the comment docs.

@xerial xerial mentioned this pull request Jul 28, 2019
66 tasks
Copy link
Copy Markdown
Member

@takezoe takezoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

trace(s"Found a recorded response: ${record.summary}")
val r = record.toResponse
// Add an HTTP header to indicate that the response is a recorded one
r.headerMap.put("X-Airframe-Record-Time", record.createdAt.toString)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@xerial xerial merged commit bbba4db into wvlet:master Jul 29, 2019
@xerial xerial deleted the recorder-book branch July 29, 2019 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants