Skip to content

airframe-http: Add HttpFilter#540

Merged
xerial merged 19 commits intowvlet:masterfrom
xerial:filtered-route
Jul 24, 2019
Merged

airframe-http: Add HttpFilter#540
xerial merged 19 commits intowvlet:masterfrom
xerial:filtered-route

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Jul 7, 2019

No description provided.

@xerial xerial mentioned this pull request Jul 7, 2019
Closed
66 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 7, 2019 •
edited
Loading

Codecov Report

Merging #540 into master will decrease coverage by 0.14%.
The diff coverage is 73.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   83.83%   83.68%   -0.15%     
==========================================
  Files         222      224       +2     
  Lines        8130     8184      +54     
  Branches      573      596      +23     
==========================================
+ Hits         6816     6849      +33     
- Misses       1314     1335      +21
Impacted Files Coverage Δ
...ttp/src/main/scala/wvlet/airframe/http/Route.scala 93.33% <0%> (-6.67%) ⬇️
...in/scala/wvlet/airframe/http/finagle/package.scala 94.44% <100%> (+0.15%) ⬆️
...rc/main/scala/wvlet/airframe/http/HttpFilter.scala 100% <100%> (ø)
...tp/src/main/scala/wvlet/airframe/http/Router.scala 56.66% <50%> (-43.34%) ⬇️
...airframe/http/finagle/FinagleResponseHandler.scala 66.66% <66.66%> (ø)
...http/src/main/scala/wvlet/airframe/http/Http.scala 78.12% <80%> (-1.88%) ⬇️
...la/wvlet/airframe/http/finagle/FinagleRouter.scala 93.93% <93.54%> (+6.43%) ⬆️
...rame-log/jvm/src/main/scala/wvlet/log/LogEnv.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb6245...f143e59. Read the comment docs.

@xerial xerial changed the title [WIP] airframe-http: HttpRequestFilter airframe-http: Add HttpFilter Jul 22, 2019
takezoe
takezoe reviewed Jul 23, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@takezoe takezoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xerial I want to ask about the basic behaviour of this filtering mechanism. Could you take a look my comment?

Comment thread airframe-http/src/main/scala/wvlet/airframe/http/HttpFilter.scala Outdated
@xerial
Copy link
Copy Markdown
Member Author

xerial commented Jul 23, 2019

@takezoe Revised the design by introducing HttpFilter and HttpContext, which can be a more natural wrapper over Finagle's Filter and Service[Req, Resp]

takezoe
takezoe approved these changes Jul 24, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@takezoe takezoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update. Looks good to me!

Comment thread airframe-http/src/main/scala/wvlet/airframe/http/HttpFilter.scala Outdated
*/
package wvlet.airframe.http

import wvlet.airframe.http.HttpFilter.Identity
Copy link
Copy Markdown
Member

@takezoe takezoe Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like unnecessary import.

@xerial xerial merged commit 1cb7096 into wvlet:master Jul 24, 2019
@xerial xerial deleted the filtered-route branch July 24, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@takezoe takezoe takezoe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xerial @takezoe