airframe-di: Show binding line numbers#530
Merged
xerial merged 11 commits intowvlet:masterfrom Jul 3, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
==========================================
+ Coverage 83.72% 83.73% +<.01%
==========================================
Files 216 217 +1
Lines 8000 8004 +4
Branches 578 577 -1
==========================================
+ Hits 6698 6702 +4
Misses 1302 1302
Continue to review full report at Codecov.
|
takezoe
approved these changes
Jul 3, 2019
Member
takezoe
left a comment
takezoe
left a comment
There was a problem hiding this comment.
Looks good to me with a trivial comment!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for showing the source code location when some binding error happens:
This also embeds SourceCode information where the binding is defined in the design. It will be shown at trace log when AirframeSession resolves the dependency. This information will be useful to draw dependency graphs of DI, which will be in another PR.