airframe-http: Add HttpClient#482
Merged
xerial merged 45 commits intowvlet:masterfrom Apr 18, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
==========================================
- Coverage 83.79% 83.62% -0.18%
==========================================
Files 193 200 +7
Lines 7586 7919 +333
Branches 684 699 +15
==========================================
+ Hits 6357 6622 +265
- Misses 1229 1297 +68
Continue to review full report at Codecov.
|
Closed
takezoe
reviewed
Apr 18, 2019
Member
Author
|
CI is failing because of jdk11 download failure. Other than that, we are good to merge this PR. |
Member
|
@xerial Thanks for your quick fix! |
This was referenced Jun 4, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a common interface and finagle-based implementation for an http client. #472