fix: Restore original log level in dotty LogTest to prevent CI test failures#3997
Merged
fix: Restore original log level in dotty LogTest to prevent CI test failures#3997
Conversation
…ailures Co-authored-by: xerial <[email protected]>
Copilot
AI
changed the title
[WIP] CI failure: LogTest.scala - "INFO didn't match with TRACE" error
fix: Restore original log level in dotty LogTest to prevent CI test failures
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI was failing with the error "INFO didn't match with TRACE" in the LogTest.scala file. The issue was that the
LogTest.run()method inairframe-dotty-testwas callingLogger.setDefaultLogLevel(LogLevel.INFO)but never restoring the original log level, causing side effects that could impact other tests running in the same JVM.Solution
Added a try-finally block to save and restore the original default log level, following the same pattern used in the regular LogTest in the airframe-log module:
This ensures that the global log level state is properly restored after the test completes, preventing interference with other tests that might have assertions about the expected log level.
Testing
dottyTest/runexecutes successfullylogJVM/testpasses all tests including "Test setting root log level"scalafmtAllcheckFixes #3996.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.