Update sbt-pack to 0.21#3992
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @xerial-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a routine dependency update, specifically upgrading the sbt-pack plugin to its latest version, 0.21. This ensures the project leverages the most recent features, bug fixes, and improvements provided by the sbt-pack library.
Highlights
- Dependency Update: I have upgraded the
sbt-packsbt plugin from version0.20to0.21.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates sbt-pack from version 0.20 to 0.21. While this is a straightforward dependency bump, my review identified a potential security concern with the new version. sbt-pack 0.21 appears to depend on a version of commons-compress with known security vulnerabilities. Please see my detailed comment on project/plugin.sbt.
| // For JMH benchmark | ||
| addSbtPlugin("pl.project13.scala" % "sbt-jmh" % "0.4.7") | ||
| addSbtPlugin("org.xerial.sbt" % "sbt-pack" % "0.20") | ||
| addSbtPlugin("org.xerial.sbt" % "sbt-pack" % "0.21") |
There was a problem hiding this comment.
The new version of sbt-pack (0.21) appears to depend on commons-compress 1.21, according to its release notes. This version of commons-compress has several known vulnerabilities (e.g., CVE-2021-36090, CVE-2021-35517) related to archive processing.
While these vulnerabilities may not be directly exploitable in your current use of sbt-pack, introducing a dependency with known CVEs is a security risk. It would be safer to avoid this update until sbt-pack uses a patched version of commons-compress. You might consider closing this PR and sticking with sbt-pack 0.20 for now, or reaching out to the sbt-pack maintainers to request a dependency update.
1 participant
About this PR
📦 Updates org.xerial.sbt:sbt-pack from
0.20to0.21📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
🔍 Files still referring to the old version number
The following files still refer to the old version number (0.20).
You might want to review and update them manually.
⚙ Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: