Skip to content

surface (fix): Fixes #3353 in building surfaces of classes with type params in Scala3#3405

Merged
xerial merged 2 commits intomainfrom
option-default-value
Feb 25, 2024
Merged

surface (fix): Fixes #3353 in building surfaces of classes with type params in Scala3#3405
xerial merged 2 commits intomainfrom
option-default-value

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Feb 25, 2024

No description provided.

@github-actions github-actions Bot added the bug label Feb 25, 2024
@xerial
Copy link
Copy Markdown
Member Author

xerial commented Feb 25, 2024 

[error] /Users/leo/work/git/airframe/airframe-surface/src/test/scala/wvlet/airframe/surface/i3363.scala:24:7: macro has not been expanded
[error]   test("With an optional value default argument") {
[error]       ^

The newly added test cases fail in Scala 2 with the above error. It needs to be fixed, but less prioritized for now.

@xerial xerial enabled auto-merge (squash) February 25, 2024 06:56
@xerial xerial merged commit a2c69a1 into main Feb 25, 2024
@xerial xerial deleted the option-default-value branch February 25, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xerial