Skip to content

rx-html (fix): Fixes #3024. Remove appended attribute and CSS style values upon cancel#3025

Merged
xerial merged 2 commits intomasterfrom
rx-attr-render
Jun 16, 2023
Merged

rx-html (fix): Fixes #3024. Remove appended attribute and CSS style values upon cancel#3025
xerial merged 2 commits intomasterfrom
rx-attr-render

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Jun 16, 2023

  • rx-html (fix): Reset appended DOM attributes on cancel
  • Manage CSS style changes

@github-actions github-actions Bot added the bug label Jun 16, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 16, 2023

Codecov Report

Merging #3025 (35cf11e) into master (eceafb1) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3025      +/-   ##
==========================================
- Coverage   82.82%   82.82%   -0.01%     
==========================================
  Files         350      350              
  Lines       14640    14640              
  Branches     2402     2402              
==========================================
- Hits        12126    12125       -1     
- Misses       2514     2515       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eceafb1...35cf11e. Read the comment docs.

@xerial xerial enabled auto-merge (squash) June 16, 2023 20:58
@xerial xerial changed the title rx-html (fix): Fixes #3024. Remove appended attribute and CSS style values upon cancel" rx-html (fix): Fixes #3024. Remove appended attribute and CSS style values upon cancel Jun 16, 2023
@xerial xerial merged commit 50b8b33 into master Jun 16, 2023
@xerial xerial deleted the rx-attr-render branch June 16, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant