Skip to content

airframe-http-netty: Improve exception handling #2927

Merged
xerial merged 7 commits intomasterfrom
http-client-error-message
May 4, 2023
Merged

airframe-http-netty: Improve exception handling #2927
xerial merged 7 commits intomasterfrom
http-client-error-message

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented May 4, 2023

  • airframe-http: Report RPCException properly during retry
  • Improve error message

@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2023

Codecov Report

Merging #2927 (c7eb8ff) into master (2b380f7) will increase coverage by 0.01%.
The diff coverage is 81.25%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2927      +/-   ##
==========================================
+ Coverage   82.80%   82.81%   +0.01%     
==========================================
  Files         345      345              
  Lines       14559    14563       +4     
  Branches     2384     2394      +10     
==========================================
+ Hits        12055    12060       +5     
+ Misses       2504     2503       -1     
Impacted Files Coverage Δ
...vlet/airframe/http/netty/NetthRequestHandler.scala 79.66% <57.14%> (-0.34%) ⬇️
...cala/wvlet/airframe/http/HttpClientException.scala 80.45% <100.00%> (+2.41%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b380f7...c7eb8ff. Read the comment docs.

@xerial xerial changed the title airframe-http: Improve error handling and disable TastySurfaceFactory in Scala 3 airframe-http-netty: Improve exception handling May 4, 2023
@xerial xerial merged commit f0b24a6 into master May 4, 2023
@xerial xerial deleted the http-client-error-message branch May 4, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant