Skip to content

airframe-http: Use Rx interface for async HTTP clients#2875

Merged
xerial merged 15 commits intomasterfrom
rx-async-client
Apr 25, 2023
Merged

airframe-http: Use Rx interface for async HTTP clients#2875
xerial merged 15 commits intomasterfrom
rx-async-client

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Apr 25, 2023

  • airframe-http: Change HTTP Aync client to Rx-based interface
  • Use Rx for async tests
  • Deprecated the old JSHttpClient interface

Closes #2300

@xerial xerial added the breaking Breaking changes label Apr 25, 2023
@github-actions github-actions Bot added the doc Documentation task label Apr 25, 2023
@xerial xerial added this to the Airframe 23 milestone Apr 25, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2023

Codecov Report

Merging #2875 (838d664) into master (15cdc8c) will decrease coverage by 0.11%.
The diff coverage is 62.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2875      +/-   ##
==========================================
- Coverage   82.78%   82.67%   -0.11%     
==========================================
  Files         341      341              
  Lines       14388    14414      +26     
  Branches     2359     2361       +2     
==========================================
+ Hits        11911    11917       +6     
- Misses       2477     2497      +20     
Impacted Files Coverage Δ
...ala/wvlet/airframe/http/codegen/RouteScanner.scala 76.47% <ø> (ø)
...rame/http/codegen/client/HttpClientGenerator.scala 100.00% <ø> (ø)
...frame/http/codegen/client/RPCClientGenerator.scala 100.00% <ø> (ø)
...http/codegen/client/ScalaHttpClientGenerator.scala 100.00% <ø> (ø)
...ala/wvlet/airframe/http/okhttp/OkHttpChannel.scala 89.28% <0.00%> (ø)
...et/airframe/http/client/URLConnectionChannel.scala 87.17% <0.00%> (ø)
...rc/main/scala/wvlet/airframe/http/HttpClient.scala 64.00% <ø> (ø)
...let/airframe/http/client/ClientLoggingFilter.scala 80.00% <ø> (ø)
...scala/wvlet/airframe/http/client/HttpChannel.scala 0.00% <ø> (ø)
...scala/wvlet/airframe/http/client/HttpClients.scala 76.69% <25.00%> (-1.61%) ⬇️
... and 6 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cdc8c...838d664. Read the comment docs.

@xerial xerial merged commit 7f79973 into master Apr 25, 2023
@xerial xerial deleted the rx-async-client branch April 25, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking changes deprecation doc Documentation task feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

airframe-http: Rx-based HTTP client implementation

1 participant