Skip to content

airframe-okhttp: Scala 3 support#2865

Merged
xerial merged 5 commits intomasterfrom
scala3-okhttp
Apr 25, 2023
Merged

airframe-okhttp: Scala 3 support#2865
xerial merged 5 commits intomasterfrom
scala3-okhttp

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Apr 25, 2023 •
edited
Loading

@xerial xerial changed the title airframe-http: Scala 3 support airframe-okhttp: Scala 3 support Apr 25, 2023
@xerial xerial marked this pull request as ready for review April 25, 2023 06:38
@xerial xerial added the breaking Breaking changes label Apr 25, 2023
@xerial xerial added this to the Scala 3 milestone Apr 25, 2023
@xerial xerial mentioned this pull request Apr 25, 2023
Closed
62 tasks
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2023

Codecov Report

Merging #2865 (4d8ccfa) into master (e42aa86) will decrease coverage by 0.04%.
The diff coverage is 82.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2865      +/-   ##
==========================================
- Coverage   82.80%   82.76%   -0.04%     
==========================================
  Files         340      341       +1     
  Lines       14437    14396      -41     
  Branches     2354     2364      +10     
==========================================
- Hits        11954    11915      -39     
+ Misses       2483     2481       -2
Impacted Files Coverage Δ
...scala/wvlet/airframe/http/client/HttpChannel.scala 0.00% <0.00%> (ø)
...scala/wvlet/airframe/http/client/HttpClients.scala 78.30% <ø> (ø)
...ain/scala/wvlet/airframe/http/okhttp/package.scala 74.00% <57.14%> (-5.17%) ⬇️
...ala/wvlet/airframe/http/okhttp/OkHttpChannel.scala 89.28% <89.28%> (ø)
...main/scala/wvlet/airframe/http/okhttp/OkHttp.scala 100.00% <100.00%> (ø)
...wvlet/airframe/http/client/JavaClientChannel.scala 95.12% <100.00%> (ø)
...c/main/scala/wvlet/airframe/http/HttpMessage.scala 87.20% <100.00%> (+0.10%) ⬆️

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e42aa86...4d8ccfa. Read the comment docs.

@xerial
Copy link
Copy Markdown
Member Author

xerial commented Apr 25, 2023

@shimamoto @takezoe This is a breaking change to support Scala 3 and reuse the same HTTP client code base as much as possible between various clients (Java9 HTTP client, URLConnectionClient, OkHttp client, etc.) The basic usage will be as described in #2440

@xerial xerial merged commit 2bb70d4 into master Apr 25, 2023
@xerial xerial deleted the scala3-okhttp branch April 25, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking Breaking changes feature

Projects

None yet

Milestone

Scala 3

Development

Successfully merging this pull request may close these issues.

1 participant

@xerial