airframe-sql: Check database name in Attribute.matched()#2809
Merged
takezoe merged 1 commit intowvlet:masterfrom Mar 25, 2023
Merged
airframe-sql: Check database name in Attribute.matched()#2809takezoe merged 1 commit intowvlet:masterfrom
takezoe merged 1 commit intowvlet:masterfrom
Conversation
takezoe
commented
Mar 25, 2023
| val e = intercept[SQLError] { | ||
| analyze( | ||
| """select default.A.name from default.A | ||
| |inner join shared.D on A.id = shared.A.id""".stripMargin |
Member
Author
There was a problem hiding this comment.
shared.A.id can be resolved wrongly without this fix.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2809 +/- ##
==========================================
+ Coverage 82.42% 82.43% +0.01%
==========================================
Files 337 337
Lines 14240 14249 +9
Branches 2361 2293 -68
==========================================
+ Hits 11737 11746 +9
Misses 2503 2503
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
takezoe
force-pushed
the
sql-fix-attribute-matched
branch
from
2777827 to
635a863
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2803
Since context is necessary for this, #2808 was not necessary. 🙇♂️