Skip to content

airframe-sql: Remove unnecessary context parameter in TypeResolver#2808

Merged
xerial merged 1 commit intowvlet:masterfrom
takezoe:sql-remove-unnecessary-args
Mar 24, 2023
Merged

airframe-sql: Remove unnecessary context parameter in TypeResolver#2808
xerial merged 1 commit intowvlet:masterfrom
takezoe:sql-remove-unnecessary-args

Conversation

@takezoe
Copy link
Copy Markdown
Member

@takezoe takezoe commented Mar 24, 2023

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2023

Codecov Report

Merging #2808 (242b3cb) into master (8adede2) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2808   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         337      337           
  Lines       14240    14240           
  Branches     2361     2361           
=======================================
  Hits        11738    11738           
  Misses       2502     2502           
Impacted Files Coverage Δ
...ala/wvlet/airframe/sql/analyzer/TypeResolver.scala 93.64% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8adede2...242b3cb. Read the comment docs.

@xerial
Copy link
Copy Markdown
Member

xerial commented Mar 24, 2023

LGTM.

@xerial xerial added the internal Internal changes (usually non-user facing) label Mar 24, 2023
@xerial xerial merged commit 7ea21b1 into wvlet:master Mar 24, 2023
@takezoe takezoe deleted the sql-remove-unnecessary-args branch March 25, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Internal changes (usually non-user facing)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants