airframe-sql: Fix full qualified column name handling#2803
airframe-sql: Fix full qualified column name handling#2803xerial merged 1 commit intowvlet:masterfrom
Conversation
| // TODO Should we handle quotation in the name or just reject such strings? | ||
| fullName.split("\\.").toList match { | ||
| case List(db, t, c) if db == contextDatabase => | ||
| case List(db, t, c) => |
There was a problem hiding this comment.
To be honest, I'm not sure if this fix is correct. 🤔
There was a problem hiding this comment.
Yeah. This fix itself should be ok.
I think Attribute.matched(ColmnPath) function needs to be implemented properly to check the context (or specified) database properly.
. This can be fixed in another PR.There was a problem hiding this comment.
It can wrongly match in the current implementation because it doesn't check the database name? Hmm, that's terrible...
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2803 +/- ##
==========================================
- Coverage 82.43% 82.42% -0.01%
==========================================
Files 337 337
Lines 14241 14240 -1
Branches 2315 2361 +46
==========================================
- Hits 11739 11738 -1
Misses 2502 2502
Continue to review full report in Codecov by Sentry.
|
2 participants
No description provided.