airframe-http: Propagate RPCException during parsing RPC requests #2794
Merged
airframe-http: Propagate RPCException during parsing RPC requests #2794
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2794 +/- ##
==========================================
+ Coverage 82.27% 82.28% +0.01%
==========================================
Files 337 337
Lines 14175 14184 +9
Branches 2332 2313 -19
==========================================
+ Hits 11662 11672 +10
+ Misses 2513 2512 -1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
xerial
changed the title
Member
Author
|
@takezoe With this change, we can add validation code inside RPC request objects |
takezoe
reviewed
Mar 21, 2023
| ) | ||
| methodArgs.toSeq | ||
| } catch { | ||
| case e: IllegalArgumentException => |
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2773