airframe-sql: Fixes #2743 Unresolve AllColumns before applying TypeResolver#2744
Merged
airframe-sql: Fixes #2743 Unresolve AllColumns before applying TypeResolver#2744
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2744 +/- ##
=======================================
Coverage 82.21% 82.22%
=======================================
Files 337 337
Lines 14125 14130 +5
Branches 2262 2279 +17
=======================================
+ Hits 11613 11618 +5
Misses 2512 2512
Continue to review full report at Codecov.
|
xerial
commented
Feb 9, 2023
| } | ||
|
|
||
| private[sql] def resolve( | ||
| def resolve( |
Member
Author
There was a problem hiding this comment.
Exposed this method if some customization (adding rules) is necessary.
takezoe
approved these changes
Feb 10, 2023
Member
takezoe
left a comment
takezoe
left a comment
There was a problem hiding this comment.
Thank you! This should be fine as we have already confirmed that clearing AllColumns.columns works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.