Skip to content

airframe-sql: Remove unnecessary parentheses in SQL generation for AliasedRelation#2739

Merged
xerial merged 1 commit intowvlet:masterfrom
takezoe:sql-generation-fix-aliased-relation
Feb 8, 2023
Merged

airframe-sql: Remove unnecessary parentheses in SQL generation for AliasedRelation#2739
xerial merged 1 commit intowvlet:masterfrom
takezoe:sql-generation-fix-aliased-relation

Conversation

@takezoe
Copy link
Copy Markdown
Member

@takezoe takezoe commented Feb 8, 2023

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 8, 2023

Codecov Report

Merging #2739 (69c40b2) into master (7651f46) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2739   +/-   ##
=======================================
  Coverage   82.20%   82.21%           
=======================================
  Files         337      337           
  Lines       14124    14124           
  Branches     2207     2242   +35     
=======================================
+ Hits        11611    11612    +1     
+ Misses       2513     2512    -1     
Impacted Files Coverage Δ
...scala/wvlet/airframe/sql/parser/SQLGenerator.scala 91.18% <100.00%> (+0.02%) ⬆️
...me-log/src/main/scala/wvlet/log/io/StopWatch.scala 80.85% <0.00%> (-0.21%) ⬇️
...rx/src/main/scala/wvlet/airframe/rx/RxRunner.scala 95.27% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7651f46...69c40b2. Read the comment docs.

@takezoe takezoe requested a review from xerial February 8, 2023 15:20
@xerial xerial merged commit a9dd85c into wvlet:master Feb 8, 2023
@xerial xerial added the kaizen code improvement without changing user-facing functionality label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kaizen code improvement without changing user-facing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants