Skip to content

airframe-sql: Handle double-quoted identifiers#2736

Merged
takezoe merged 1 commit intowvlet:masterfrom
takezoe:sql-double-quotes
Feb 7, 2023
Merged

airframe-sql: Handle double-quoted identifiers#2736
takezoe merged 1 commit intowvlet:masterfrom
takezoe:sql-double-quotes

Conversation

@takezoe
Copy link
Copy Markdown
Member

@takezoe takezoe commented Feb 7, 2023

No description provided.

@takezoe takezoe marked this pull request as ready for review February 7, 2023 07:25
@takezoe takezoe requested a review from xerial February 7, 2023 07:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 7, 2023

Codecov Report

Merging #2736 (e2b9c6a) into master (641ffbb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2736      +/-   ##
==========================================
+ Coverage   82.19%   82.20%   +0.01%     
==========================================
  Files         337      337              
  Lines       14119    14124       +5     
  Branches     2261     2207      -54     
==========================================
+ Hits        11605    11611       +6     
+ Misses       2514     2513       -1     
Impacted Files Coverage Δ
...in/scala/wvlet/airframe/sql/model/Expression.scala 72.66% <100.00%> (+0.27%) ⬆️
...ala/wvlet/airframe/sql/parser/SQLInterpreter.scala 89.92% <100.00%> (+0.04%) ⬆️
...frame-rx/src/main/scala/wvlet/airframe/rx/Rx.scala 85.18% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641ffbb...e2b9c6a. Read the comment docs.

@xerial
Copy link
Copy Markdown
Member

xerial commented Feb 7, 2023

LGTM. Thanks!

@takezoe takezoe merged commit 7651f46 into wvlet:master Feb 7, 2023
@takezoe takezoe deleted the sql-double-quotes branch February 7, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants