Skip to content

airframe-launcher: Allow '-' in option name#2733

Merged
xerial merged 1 commit intowvlet:masterfrom
takezoe:launcher-allow-dash-in-option-name
Feb 3, 2023
Merged

airframe-launcher: Allow '-' in option name#2733
xerial merged 1 commit intowvlet:masterfrom
takezoe:launcher-allow-dash-in-option-name

Conversation

@takezoe
Copy link
Copy Markdown
Member

@takezoe takezoe commented Feb 3, 2023

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 3, 2023

Codecov Report

Merging #2733 (78f9b27) into master (25fbb2d) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2733   +/-   ##
=======================================
  Coverage   82.20%   82.20%           
=======================================
  Files         337      337           
  Lines       14119    14119           
  Branches     2261     2261           
=======================================
  Hits        11606    11606           
  Misses       2513     2513           
Impacted Files Coverage Δ
...n/scala/wvlet/airframe/launcher/OptionParser.scala 82.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25fbb2d...78f9b27. Read the comment docs.

@xerial
Copy link
Copy Markdown
Member

xerial commented Feb 3, 2023

Thanks. I noticed this issue when developing a CLI application ...

@xerial xerial merged commit 9f34f8d into wvlet:master Feb 3, 2023
xerial pushed a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants