Skip to content

airframe-http-recorder: Scala 3 support#2671

Merged
xerial merged 12 commits intomasterfrom
http-recorder-scala3
Apr 25, 2023
Merged

airframe-http-recorder: Scala 3 support#2671
xerial merged 12 commits intomasterfrom
http-recorder-scala3

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Dec 26, 2022 •
edited
Loading

@xerial xerial mentioned this pull request Dec 29, 2022
Closed
8 tasks
@xerial xerial force-pushed the http-recorder-scala3 branch from 61df6cc to 6201f8d Compare April 24, 2023 21:15
@xerial xerial added the breaking Breaking changes label Apr 24, 2023
@xerial xerial marked this pull request as ready for review April 25, 2023 01:29
@xerial xerial added this to the Scala 3 milestone Apr 25, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Merging #2671 (7ddcc50) into master (329d0d0) will increase coverage by 0.11%.
The diff coverage is 83.87%.

❗ Current head 7ddcc50 differs from pull request most recent head cfa267a. Consider uploading reports for the commit cfa267a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2671      +/-   ##
==========================================
+ Coverage   82.69%   82.80%   +0.11%     
==========================================
  Files         339      340       +1     
  Lines       14392    14437      +45     
  Branches     2367     2354      -13     
==========================================
+ Hits        11901    11955      +54     
+ Misses       2491     2482       -9
Impacted Files Coverage Δ
...vlet/airframe/http/netty/NetthRequestHandler.scala 79.31% <0.00%> (ø)
...ame/http/router/HttpEndpointExecutionContext.scala 100.00% <ø> (+4.76%) ⬆️
...rc/main/scala/wvlet/airframe/http/HttpHeader.scala 0.00% <0.00%> (ø)
...rc/main/scala/wvlet/airframe/http/RxEndpoint.scala 0.00% <ø> (ø)
...et/airframe/http/router/RedirectToRxEndpoint.scala 0.00% <0.00%> (ø)
...in/scala/wvlet/airframe/http/router/RxRouter.scala 42.22% <28.57%> (-2.52%) ⬇️
...scala/wvlet/airframe/http/netty/NettyBackend.scala 58.62% <60.00%> (+4.45%) ⬆️
.../src/main/scala/wvlet/airframe/http/RxFilter.scala 66.66% <66.66%> (+66.66%) ⬆️
.../main/scala/wvlet/airframe/http/router/Route.scala 85.00% <75.00%> (+3.75%) ⬆️
.../scala/wvlet/airframe/http/netty/NettyServer.scala 94.11% <100.00%> (+4.32%) ⬆️
... and 10 more

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329d0d0...cfa267a. Read the comment docs.

@xerial
Copy link
Copy Markdown
Member Author

xerial commented Apr 25, 2023

@takezoe With this PR, airframe-http-recorder will work in Scala 3 by using the Netty backend server, instead of Finagle. A breaking change is that the interface needs to use HttpMessage.{Request, Response} becaue we can't use Finagle request/response types in Scala 3.

@xerial xerial merged commit e42aa86 into master Apr 25, 2023
@xerial xerial deleted the http-recorder-scala3 branch April 25, 2023 01:52
@xerial xerial mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breaking Breaking changes feature

Projects

None yet

Milestone

Scala 3

Development

Successfully merging this pull request may close these issues.

1 participant

@xerial