airframe-surface: Do not traverse non-public constructor#2199
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2199 +/- ##
=======================================
Coverage 82.61% 82.62%
=======================================
Files 313 313
Lines 12357 12357
Branches 780 780
=======================================
+ Hits 10209 10210 +1
+ Misses 2148 2147 -1
Continue to review full report at Codecov.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surface for Scala 3 tried to traverse ServerServiceDefinition in grpc-java too deep and caused
java.util.NoSuchElementException: key not found: <special-ops>.<FromJavaObject>error.This PR provides a workaround so as not to traverse private constructors, which might have tricky java classes.
After a new version of AirSpec with this fix is released, DI with gRPC will work.
We still need a fix for #2194