Skip to content

Build AirSpec using a sub project#1992

Merged
xerial merged 9 commits intomasterfrom
extract-airspec
Dec 26, 2021
Merged

Build AirSpec using a sub project#1992
xerial merged 9 commits intomasterfrom
extract-airspec

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Dec 24, 2021 •
edited
Loading

This is for simplifying build configuration as IntelliJ IDEA cannot properly scan source code files referenced multiple times in the same projects.

  • Split AirSpec as a sub project within the same GitHub repository
  • Use libraryDependency for AirSpec
  • Tell @SethTisue that we need to change the build configuration of the scala community build to build AirSpec for Scala JVM like this:
cd airspec
sbt +airspecJVM/publishLocal

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 24, 2021 •
edited
Loading

Codecov Report

Merging #1992 (bb06232) into master (9d96fc1) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1992      +/-   ##
==========================================
- Coverage   82.64%   82.52%   -0.13%     
==========================================
  Files         317      301      -16     
  Lines       12166    11828     -338     
  Branches      770      748      -22     
==========================================
- Hits        10055     9761     -294     
+ Misses       2111     2067      -44
Impacted Files Coverage Δ
airspec/src/main/scala/wvlet/airspec/AirSpec.scala
...ain/scala/wvlet/airspec/spi/AirSpecException.scala
...spec/src/main/scala/wvlet/airspec/AirSpecDef.scala
.../main/scala/wvlet/airspec/runner/AirSpecTask.scala
...rspec/src/main/scala/wvlet/airspec/CompatApi.scala
...c/main/scala/wvlet/airspec/spi/PropertyCheck.scala
...src/main/scala/wvlet/airspec/spi/RichAsserts.scala
.../scala/wvlet/airspec/runner/AirSpecSbtRunner.scala
...scala/wvlet/airspec/runner/AirSpecTaskRunner.scala
...pec/src/main/scala/wvlet/airspec/spi/Asserts.scala
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d96fc1...bb06232. Read the comment docs.

@xerial xerial merged commit 9994d21 into master Dec 26, 2021
@xerial xerial mentioned this pull request Feb 3, 2022
Closed
62 tasks
@exoego exoego deleted the extract-airspec branch February 4, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xerial