Skip to content

airframe-rpc: Add RPC status code#1973

Merged
xerial merged 21 commits intomasterfrom
rpc-error-handling
Apr 26, 2022
Merged

airframe-rpc: Add RPC status code#1973
xerial merged 21 commits intomasterfrom
rpc-error-handling

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Dec 14, 2021 •
edited
Loading

This PR adds RPC status code, independent from the backend implementation (e.g, gRPC or Finagle)

RPCException class will be refined later for the usability.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 14, 2021 •
edited
Loading

Codecov Report

Merging #1973 (287d471) into master (3e0b322) will increase coverage by 0.13%.
The diff coverage is 85.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1973      +/-   ##
==========================================
+ Coverage   82.50%   82.63%   +0.13%     
==========================================
  Files         301      305       +4     
  Lines       11836    12024     +188     
  Branches      736      746      +10     
==========================================
+ Hits         9765     9936     +171     
- Misses       2071     2088      +17
Impacted Files Coverage Δ
...rframe/http/grpc/internal/GrpcRequestHandler.scala 74.40% <ø> (ø)
.../grpc/internal/GrpcResponseHeaderInterceptor.scala 100.00% <ø> (ø)
...http/src/main/scala/wvlet/airframe/http/Http.scala 75.47% <ø> (ø)
...rc/main/scala/wvlet/airframe/http/HttpStatus.scala 91.20% <0.00%> (-8.80%) ⬇️
.../main/scala/wvlet/airframe/http/RPCException.scala 0.00% <0.00%> (ø)
.../main/scala/wvlet/airframe/msgpack/spi/Value.scala 82.39% <ø> (ø)
...let/airframe/surface/reflect/ReflectTypeUtil.scala 84.44% <ø> (ø)
...c/main/scala/wvlet/airframe/http/HttpMessage.scala 80.35% <66.66%> (-0.38%) ⬇️
...rc/main/scala/wvlet/airframe/http/GrpcStatus.scala 87.87% <87.87%> (ø)
...et/airframe/http/grpc/internal/GrpcException.scala 73.68% <90.00%> (+50.95%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0b322...287d471. Read the comment docs.

@xerial xerial force-pushed the rpc-error-handling branch from 9330a1a to 984195c Compare December 15, 2021 07:04
@xerial xerial force-pushed the rpc-error-handling branch from 6163207 to 1b94069 Compare January 4, 2022 04:57
@xerial xerial mentioned this pull request Jan 9, 2022
Closed
@xerial xerial force-pushed the rpc-error-handling branch from a03c3fc to 23440a5 Compare February 13, 2022 18:31
@xerial xerial force-pushed the rpc-error-handling branch from ec9e160 to 8065f23 Compare April 14, 2022 05:57
@xerial xerial marked this pull request as ready for review April 26, 2022 22:21
@xerial xerial changed the title airframe-rpc error handling airframe-rpc: Add RPC status code Apr 26, 2022
@xerial xerial merged commit dccb460 into master Apr 26, 2022
@xerial xerial mentioned this pull request Apr 27, 2022
Closed
@xerial xerial deleted the rpc-error-handling branch June 2, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xerial