Skip to content

airfram-http-grpc: Add gRPC logging#1444

Merged
xerial merged 19 commits intowvlet:masterfrom
xerial:grpc-log
Jan 21, 2021
Merged

airfram-http-grpc: Add gRPC logging#1444
xerial merged 19 commits intowvlet:masterfrom
xerial:grpc-log

Conversation

@xerial
Copy link
Copy Markdown
Member

@xerial xerial commented Jan 19, 2021 •
edited
Loading

  • Support adding Metadata to the request context
  • Log data to a local file as in airframe-http-finagle

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 19, 2021 •
edited
Loading

Codecov Report

Merging #1444 (453815b) into master (ffbcc70) will increase coverage by 0.01%.
The diff coverage is 87.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1444      +/-   ##
==========================================
+ Coverage   83.06%   83.08%   +0.01%     
==========================================
  Files         298      299       +1     
  Lines       11875    11948      +73     
  Branches      766      726      -40     
==========================================
+ Hits         9864     9927      +63     
- Misses       2011     2021      +10
Impacted Files Coverage Δ
.../wvlet/airframe/http/grpc/GrpcRequestHandler.scala 76.59% <72.00%> (ø)
...in/scala/wvlet/airframe/http/grpc/GrpcServer.scala 64.58% <75.00%> (-3.60%) ⬇️
...a/wvlet/airframe/http/grpc/GrpcRequestLogger.scala 87.87% <87.87%> (ø)
...cala/wvlet/airframe/http/HttpAccessLogWriter.scala 89.65% <89.65%> (ø)
...rame/http/finagle/filter/HttpAccessLogFilter.scala 83.54% <100.00%> (-0.86%) ⬇️
...n/scala/wvlet/airframe/http/grpc/GrpcContext.scala 100.00% <100.00%> (ø)
.../wvlet/airframe/http/grpc/GrpcServiceBuilder.scala 94.87% <100.00%> (+0.58%) ⬆️
...vm/src/main/scala/wvlet/airframe/http/Router.scala 88.23% <100.00%> (+0.14%) ⬆️
.../main/scala/wvlet/airframe/http/router/Route.scala 84.21% <100.00%> (+0.87%) ⬆️
...og/jvm/src/main/scala/wvlet/log/AsyncHandler.scala 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffbcc70...453815b. Read the comment docs.

@xerial xerial merged commit 7991d6c into wvlet:master Jan 21, 2021
@xerial xerial mentioned this pull request Feb 15, 2021
Closed
90 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xerial